Use Faster FSM #1175
Merged
Use Faster FSM #1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lapp0
force-pushed
the
performant-fsm
branch
from
6819bd6
to
5fe93d1
Compare
rlouf
reviewed
Sep 27, 2024
| """Guide to generate text in the language of a regular expression.""" | ||
|
|
||
| initial_state = 0 | ||
| class RegexGuide(CoreRegexGuide): |
There was a problem hiding this comment.
Why do we need to keep the RegexGuide here?
There was a problem hiding this comment.
This is the cached implementation of RegexGuide. Only __init__.py is changed to enable caching.
rlouf
reviewed
Sep 27, 2024
Comment on lines
210
to
227
| def test_vllm_json_schema(model): | ||
| prompt = "Output some JSON. " | ||
|
|
||
| schema = """{ | ||
| "title": "spam", | ||
| "type": "object", | ||
| "properties": { | ||
| "foo" : {"type": "boolean"}, | ||
| "bar": {"type": "string", "maxLength": 4} | ||
| }, | ||
| "required": ["foo", "bar"] | ||
| } | ||
| """ | ||
|
|
||
| sampling_params = SamplingParams(temperature=0) | ||
| result = generate.json(model, schema, whitespace_pattern="")( | ||
| prompt, max_tokens=100, seed=10, sampling_params=sampling_params | ||
| ) |
There was a problem hiding this comment.
Why are we removing the vLLM integration tests in this PR? It should at least be a separate commit.
There was a problem hiding this comment.
This was a mistake, reverted.
lapp0
force-pushed
the
performant-fsm
branch
2 times, most recently
from
7873cfc
to
857b902
Compare
lapp0
force-pushed
the
performant-fsm
branch
from
857b902
to
90f7144
Compare
|
LGTM! |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.